feat: add avs manager #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| // String implements the Stringer interface. | ||
| func (p Params) String() string { | ||
| out, _ := yaml.Marshal(p) |
Check warning
Code scanning / gosec
Returned error is not propagated up the stack. Warning
mikebraver
force-pushed
the
feat/avs-manager
branch
from
cc5a56b to
96ded64
Compare
mikebraver
force-pushed
the
feat/avs-manager
branch
3 times, most recently
from
3abf8d2 to
6bce504
Compare
| } | ||
|
|
||
| message RegisterAVSTaskReq { | ||
| string AVSAddress = 1; |
There was a problem hiding this comment.
Registering tasks might need permission control, maybe only the owner of the AVS can register its task? It seems like this RPC can be called anyone.
There was a problem hiding this comment.
It will check the author address to make sure it's valid operator address, and bls for verification
There was a problem hiding this comment.
Missing: the assets supported by the AVS, correct? Will it be implemented in a quorum form?
mikebraver
force-pushed
the
feat/avs-manager
branch
from
c6cd627 to
7f65704
Compare
mikebraver
force-pushed
the
feat/avs-manager
branch
from
7f65704 to
2eb086a
Compare
mikebraver
requested review from
rlan35,
bwhour,
MaxMustermann2,
trestinlsd,
TimmyExogenous and
leonz789
bwhour
reviewed
Apr 9, 2024
mikebraver
force-pushed
the
feat/avs-manager
branch
2 times, most recently
from
0c748a7 to
89d1b0e
Compare
trestinlsd
approved these changes
Apr 10, 2024
mikebraver
force-pushed
the
feat/avs-manager
branch
5 times, most recently
from
f0b2e21 to
5974130
Compare
leonz789
approved these changes
Apr 10, 2024
mikebraver
force-pushed
the
feat/avs-manager
branch
2 times, most recently
from
939d12d to
124bebc
Compare
TimmyExogenous
approved these changes
Apr 10, 2024
mikebraver
force-pushed
the
feat/avs-manager
branch
from
124bebc to
3467ea8
Compare
mikebraver
force-pushed
the
feat/avs-manager
branch
from
3467ea8 to
bbd2a05
Compare
MaxMustermann2
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add avs manager to manage avs, operator with exocore chain